Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fireplaces to bond integration #37850

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

prystupa
Copy link
Contributor

Proposed change

Add Bond-controlled fireplaces to bond integration, exposing them as lights (on/off) with brightness (flame level)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@ctalkington
Copy link
Contributor

im wondering if any other fireplaces have been implemented as this feels a bit hacky to me.

@prystupa
Copy link
Contributor Author

prystupa commented Jul 15, 2020

im wondering if any other fireplaces have been implemented as this feels a bit hacky to me.

I search through HA for 'fireplace' and there is no patterns at all I can find. Surprisingly, there is no 'FireplaceEntity' either. Though the 'light' domain with fireplace icon approach looks reasonable to me (fireplace works a lot like dimmer), I am open to suggestions...

@ctalkington
Copy link
Contributor

ctalkington commented Jul 15, 2020

totally get it where you are coming from.

Out of curiousity, reading the docs it says:

For Fireplaces, it refers to the state of the flame. Note that many fireplaces have separate light or fan functions, which are not governed by the Power feature.

Do the fans/lights get handled by prior code or would they have to be added after this?

@prystupa
Copy link
Contributor Author

totally get it where you are coming from.

Out of curiousity, reading the docs it says:

For Fireplaces, it refers to the state of the flame. Note that many fireplaces have separate light or fan functions, which are not governed by the Power feature.

Do the fans/lights get handled by prior code or would they have to be added after this?

They would have to be added after this as they all use special Bond commands - I just started with 'main' fireplace device first - fire, as I expect that is what people are mostly interested in automating...

Copy link
Contributor

@ctalkington ctalkington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im going to approve this as i dont really see a better way to represent a fireplace with flame intensity with current platforms. Flames (fire) are a type of light in a broad sense so its not so far fetched.

@ctalkington
Copy link
Contributor

I do have one concern since fireplaces can have lights and fans per docs. itll be important to set names such as "{device name} Light" or "{device name} Fan" if they dont come from bond as such if/when you extend the support.

@ctalkington ctalkington merged commit b07d09f into home-assistant:dev Jul 15, 2020
@prystupa prystupa deleted the bond-fireplace branch July 15, 2020 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants