-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for fireplaces to bond integration #37850
Conversation
im wondering if any other fireplaces have been implemented as this feels a bit hacky to me. |
I search through HA for 'fireplace' and there is no patterns at all I can find. Surprisingly, there is no 'FireplaceEntity' either. Though the 'light' domain with fireplace icon approach looks reasonable to me (fireplace works a lot like dimmer), I am open to suggestions... |
totally get it where you are coming from. Out of curiousity, reading the docs it says:
Do the fans/lights get handled by prior code or would they have to be added after this? |
They would have to be added after this as they all use special Bond commands - I just started with 'main' fireplace device first - fire, as I expect that is what people are mostly interested in automating... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im going to approve this as i dont really see a better way to represent a fireplace with flame intensity with current platforms. Flames (fire) are a type of light in a broad sense so its not so far fetched.
I do have one concern since fireplaces can have lights and fans per docs. itll be important to set names such as "{device name} Light" or "{device name} Fan" if they dont come from bond as such if/when you extend the support. |
Proposed change
Add Bond-controlled fireplaces to bond integration, exposing them as lights (on/off) with brightness (flame level)
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: