Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure entries appear when using the logbook.log service without a domain/entity_id #37388

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jul 2, 2020

Proposed change

Ensure logbook entries appear when using the logbook.log
service without a domain or entity_id.

This regressed when I fixed the filtering in #36973

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

service without a domain or entity_id
@bdraco bdraco added this to the 0.112.2 milestone Jul 2, 2020
@bdraco bdraco changed the title Ensure logbook entries appear when using the logbook.log service Ensure entries appear when using the logbook.log service without a domain/entity_id Jul 2, 2020
@bdraco bdraco merged commit 7e664fb into home-assistant:dev Jul 3, 2020
@bdraco bdraco mentioned this pull request Jul 3, 2020
20 tasks
balloob pushed a commit that referenced this pull request Jul 3, 2020
@balloob balloob mentioned this pull request Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants