Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Recent refactoring PR #37232 created a serious issue with the Influx sensor. The test query to determine connectivity with Influx V1 was
SHOW SERIES LIMIT 1;
. I thought that this query was one that worked with or without a database specified and thus could just be used to determine connectivity with the server, similar to howbuckets()
is used with V2 Influx. This is incorrect, database is not optional. Therefore when used during initial setup to test connectivity outside of the context of any particular sensor this can break.This PR simply changes the query to
SHOW DATABASES;
which does work in this context. It always returns the list of databases the currently authenticated user can see based on privileges. Will follow this up with another PR to use this info to validate the sensors are pointing to valid databases/buckets but for now just fixing the introduced bug.Type of change
Example entry for
configuration.yaml
:V1:
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: