Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up plum_lightpad #37077

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Clean up plum_lightpad #37077

merged 1 commit into from
Jun 25, 2020

Conversation

prystupa
Copy link
Contributor

@prystupa prystupa commented Jun 24, 2020 •
edited by MartinHjelmare
Loading

Proposed change

Small refactoring to use preferred HA way to create tasks, per feedback from HA developer

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@MartinHjelmare MartinHjelmare changed the title apply small refactoring per feedback in previous PR regarding creatin… Clean up plum_lightpad Jun 25, 2020
MartinHjelmare
MartinHjelmare approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit fea5d00 into home-assistant:dev Jun 25, 2020
@prystupa prystupa deleted the plum_refactor branch June 25, 2020 11:59
@frenck frenck added this to the 0.112.0 milestone Jun 25, 2020
balloob pushed a commit that referenced this pull request Jun 26, 2020
@prystupa @balloob
Clean up plum_lightpad (#37077)
508afd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed code-quality integration: plum_lightpad small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.112.0
Development

Successfully merging this pull request may close these issues.
5 participants
@prystupa @MartinHjelmare @frenck @balloob @homeassistant