-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Plum Lightpad config flow #36802
Conversation
Hey there @ColinHarrington, mind taking a look at this pull request as its been labeled with a integration ( |
…ntended change to requirements_test_all.txt)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Looks like the way you did this handles configuration.yaml and config flow.
I appreciate adding types where applicable.
I had a few things to address:
- The cleanup function/shutdown hook
- potential naming questions
use debug instead of info for logging Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
switch to use generated references instead of hard-coded strings Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
switch to use references instead of hard-coded string Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
removing translated title per suggestion Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
removing per suggestion Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
…nfiguration.yaml scenario
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Ok to merge when last comments addressed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's shaping up well. I have a few requested changes/clarifications.
I'd also like to confirm it's working with actual devices first before merging.
use helper instead of custom code/message-id Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Yes, I have tested this code with real devices at my home. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you for going back and forth on the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments in a new PR.
Tests were not added for the config flow in this PR. We require 100% coverage for the config flow module. Run the scaffold script to generate test example code.
The documentation for this PR is missing, or am I looking incorrect? |
Documentation update PR added: home-assistant/home-assistant.io#13869 |
Documented here: home-assistant/home-assistant.io#13870 |
Proposed change
This PR makes it possible for Plum Lightpad integration to be configured via config flow from UI and/or from existing configuration in configuration.yaml.
This PR also exposes Plum dimmers and glow rings as devices, so that they can be manipulated in automations.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: