Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coronavirus worldwide sum #36737

Merged
merged 3 commits into from
Jun 23, 2020
Merged

Fix coronavirus worldwide sum #36737

merged 3 commits into from
Jun 23, 2020

Conversation

MartinHjelmare
Copy link
Member

@MartinHjelmare MartinHjelmare commented Jun 12, 2020

Breaking change

Proposed change

  • Fix sum for worldwide sensors when an addend is None.
  • Return None if any of the addends (countries) are None.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @home_assistant/core, mind taking a look at this pull request as its been labeled with a integration (coronavirus) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare
Copy link
Member Author

I'll add some sensor tests.

@stickpin
Copy link
Contributor

@MartinHjelmare, @frenck any planes to merge the fix?

Thanks in advance!

@frenck frenck self-requested a review June 21, 2020 16:14
@frenck frenck self-assigned this Jun 21, 2020
Co-authored-by: Franck Nijhof <git@frenck.dev>
@stickpin
Copy link
Contributor

@frenck can you approve please and include it into the next Milestone? :)

@MartinHjelmare
Copy link
Member Author

MartinHjelmare commented Jun 22, 2020

I haven't pushed the tests yet. Please be patient and don't spam this PR.

@balloob balloob merged commit 149a316 into dev Jun 23, 2020
@balloob balloob deleted the fix-coronavirus-worldwide branch June 23, 2020 04:22
@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coronavirus Integration - Worldwide Current and Recovered sensors are unavailable
5 participants