Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MDI CPU icon for glances #36736

Merged
merged 2 commits into from
Jun 16, 2020
Merged

Conversation

spacegaier
Copy link
Member

Proposed change

Use the correct MDI CPU icon (instead of the memory icon). Bit architecture is dynamically detected to show the correct icon variant.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @fabaff, @engrbm87, mind taking a look at this pull request as its been labeled with a integration (glances) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@spacegaier
Copy link
Member Author

Not really sure what to do about the codecov/path failure. Any ideas?

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fabaff fabaff mentioned this pull request Jun 14, 2020
20 tasks
@MartinHjelmare MartinHjelmare self-assigned this Jun 16, 2020
@MartinHjelmare MartinHjelmare changed the title Use MDI CPU icon (bit architecture determined at runtime) Use MDI CPU icon for glances Jun 16, 2020
@MartinHjelmare MartinHjelmare merged commit 25607c7 into home-assistant:dev Jun 16, 2020
@spacegaier spacegaier deleted the glances branch June 16, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants