Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Axis option to enable/disable camera #36420

Merged

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Jun 3, 2020

Breaking change

Proposed change

Camera entity can be disabled by user. The option was created a long time ago and is no longer the recommended way of doing it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@Kane610 Kane610 self-assigned this Jun 3, 2020
@MartinHjelmare MartinHjelmare changed the title Axis - Remove the option to enable/disable camera Remove Axis option to enable/disable camera Jun 4, 2020
@MartinHjelmare MartinHjelmare merged commit 99318b7 into home-assistant:dev Jun 4, 2020
@Kane610
Copy link
Member Author

Kane610 commented Jun 4, 2020

Woohoo! Thanks @MartinHjelmare

@Kane610 Kane610 deleted the axis-no_option_to_disable_camera branch June 4, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants