-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Speedtestdotnet config_flow #36254
Add Speedtestdotnet config_flow #36254
Conversation
Hey there @rohankapoorcom, mind taking a look at this pull request as its been labeled with a integration ( |
…edtestdotnet-configflow
…edtestdotnet-configflow
We need to register a listener for the config entry and have a callback change the update interval on the coordinator. https://developers.home-assistant.io/docs/config_entries_options_flow_handler#signal-updates |
…edtestdotnet-configflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @engrbm87 - thanks for putting the work in to convert this to a config flow. I've been wanting to do it myself, but have other things take priority over much of open source contributions!
I'm glad to have to join as a code owner for the integration, but I would appreciate not being removed from it.
Thanks again for your contribution. I haven't formally reviewed all of it, but overall, it looks good to me.
Hello @rohankapoorcom , sorry for removing your name by mistake. I will sure add it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Could we try to import the config yaml to a config entry to ease the transition for users? |
Currently the config yaml includes |
I'm thinking we just import the server_id and validate that against available ids. If good, create the entry, if not good, abort. |
Ok, let me work on that. |
This comment has been minimized.
This comment has been minimized.
…edtestdotnet-configflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, one comment more.
Please update the breaking change paragraph and mention what options from the config yaml will be imported. |
Are we ready to merge? |
Woo-hoo! Nice work @engrbm87! |
Breaking change
Integration is now configured through the UI. To successfully import from
configuration.yaml
please removemonitored_conditions
. Ifserver_id
is mentioned it will checked against the list of servers before importing.Proposed change
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: