Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check todoist due date is not None in async_get_events #36140

Merged
merged 2 commits into from
May 26, 2020

Conversation

gadgetchnnel
Copy link
Contributor

Check that due date is not None, prevents taks without due dates from breaking Calendar API

Breaking change

Proposed change

The Todoist integration throws an error in the async_get_events method if there is a task without a due date, preventing them for working correctly with the Calendar API. This PR adds a check that the due date is not None before checking if the due date is within the date range being requested.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: 35921
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Check that due date is not None, prevents taks without due dates from breaking Calendar API
@probot-home-assistant
Copy link

Hey there @boralyl, mind taking a look at this pull request as its been labeled with a integration (todoist) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title Todoist - Check that due date is not None in async_get_events Check todoist due date is not None in async_get_events May 26, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cgarwood cgarwood added this to the 0.110.4 milestone May 26, 2020
@cgarwood cgarwood merged commit 514c646 into home-assistant:dev May 26, 2020
@gadgetchnnel gadgetchnnel deleted the todoist-no-due-date-fix branch May 26, 2020 18:08
balloob pushed a commit that referenced this pull request May 28, 2020
* Check that due date is not None

Check that due date is not None, prevents taks without due dates from breaking Calendar API

* Invert None check to reduce indentation
@balloob balloob mentioned this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants