Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported stop feature with Hunter Douglas Powerview 1.0 Hubs #36129

Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 25, 2020

Proposed change

Hunter Douglas Powerview 1.0 Hubs do not support stop

Remove stop as a supported feature for powerview 1.0 hubs as it is not supported by the hub.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Remove stop as a supported feature for 1.0 hubs.
@bdraco bdraco added this to the 0.110.3 milestone May 25, 2020
@bdraco bdraco changed the title Hunter Douglas Powerview 1.0 Hubs do not support stop Remove unsupported stop feature for Hunter Douglas Powerview 1.0 Hubs May 25, 2020
@bdraco bdraco changed the title Remove unsupported stop feature for Hunter Douglas Powerview 1.0 Hubs Remove unsupported stop feature with Hunter Douglas Powerview 1.0 Hubs May 25, 2020
@frenck frenck merged commit 73fa617 into home-assistant:dev May 25, 2020
@frenck frenck mentioned this pull request May 26, 2020
kennedyshead pushed a commit to kennedyshead/home-assistant that referenced this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hunter Douglas Powerview - Error on selecting blind stop
3 participants