Make generic camera stream_source a template

[zvldz]

Breaking change

Proposed change

stream_source can be a template.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

camera: # another instance camera
  - name: camera
    platform: generic
    stream_source: http://192.xx.xx.xx:8123/api/camera_proxy/camera.camera?token={{ states('sensor.camera_token') }}
    still_image_url: http://192.xx.xx.xx:8123/api/camera_proxy/camera.camera?token={{ states('sensor.camera_token') }}

Additional information

• This PR fixes or closes issue: fixes Generic camera stops updating template stream_source/still_image_url #35346
• This PR is related to issue:
• Link to documentation pull request: Make generic camera stream_source a template home-assistant.io#13719

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[homeassistant]

Hi @zvldz,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[Spirituss]

This fix works fine for me and closes issue: #35346.

[alting]

I confirm this problem. waiting for a decision

[to4ko]

exactly what i was looking for! working fine with this fix!

[tayanov]

+1

[zvldz]

Dear developers, please comment.

[zvldz]

What am I doing wrong? Why am I being ignored ?

[MartinHjelmare]

You're not being actively ignored. There are more than 200 open PRs. Please be patient.

[MartinHjelmare]

Looks good!

[MartinHjelmare]

Please add a test that covers the new feature. We can probably do something similar as this test:

core/tests/components/generic/test_camera.py

Line 95 in a68af0a

async def test_limit_refetch(aioclient_mock, hass, hass_client):

It also uses a template but for the still image url.

[zvldz]

Please add a test that covers the new feature. We can probably do something similar as this test:

I am not sure if I did the test correctly.
Please correct me if I'm wrong.

[MartinHjelmare]

I've added tests.

[zvldz]

I've added tests.

Thank you!

[MartinHjelmare]

Not sure what's going on with the Python 3.8 build. I'll dig more tomorrow.