Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rokuecp to 0.4.2 #36102

Merged
merged 3 commits into from
May 25, 2020
Merged

Update rokuecp to 0.4.2 #36102

merged 3 commits into from
May 25, 2020

Conversation

ctalkington
Copy link
Contributor

@ctalkington ctalkington commented May 24, 2020 •
edited
Loading

Breaking change

Proposed change

This release includes a basic fix for search keypress loading home rather than search interface.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@ctalkington ctalkington added this to the 0.110.3 milestone May 24, 2020
cgtobi
cgtobi approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@cgtobi cgtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgtobi cgtobi merged commit 22a2c38 into dev May 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the ctalkington-roku-042 branch May 25, 2020 11:40
frenck pushed a commit that referenced this pull request May 26, 2020
@ctalkington @frenck
Update rokuecp to 0.4.2 (#36102)
a1eb513 
* update rokuecp to 0.4.2

* Update requirements_all.txt

* Update requirements_test_all.txt
@frenck frenck mentioned this pull request May 26, 2020
Merged
kennedyshead pushed a commit to kennedyshead/home-assistant that referenced this pull request May 28, 2020
@ctalkington @MagnusKnutas
Update rokuecp to 0.4.2 (home-assistant#36102)
cfc2acc 
* update rokuecp to 0.4.2

* Update requirements_all.txt

* Update requirements_test_all.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgtobi cgtobi cgtobi approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed dependency dependency-bump integration: roku small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.110.3
Development

Successfully merging this pull request may close these issues.

Roku search not working
4 participants
@ctalkington @cgtobi @frenck @homeassistant