Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roku tv input names to alexa inputs #36089

Merged
merged 2 commits into from
May 25, 2020
Merged

Conversation

ctalkington
Copy link
Contributor

@ctalkington ctalkington commented May 24, 2020

Breaking change

Proposed change

Roku TV exposes most inputs by their device type ie bluray player or antenna tv rather than HDMI1 etc.

This helps pick up a few of the more common Roku TV namings to improve voice control with Alexa.

I went for "TUNER" for Antenna because saying "Alexa, change the input to TV on the Living Room TV" is a bit confusing" either TUNER or TV make sense in the case of Antenna since its treated as an input

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @home-assistant/cloud, @ochlocracy, mind taking a look at this pull request as its been labeled with a integration (alexa) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgarwood cgarwood merged commit 6541954 into dev May 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the ctalkington-alexa-roku-input branch May 25, 2020 20:06
kennedyshead pushed a commit to kennedyshead/home-assistant that referenced this pull request May 28, 2020
* add roku tv input names to alexa inputs

* Update const.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants