Notify user if arming or disarming totalconnect alarm fails

[austinmroczek]

Proposed change

Create a persistent notification to tell a user that their attempt to arm or disarm their TotalConnect alarm system failed. Add tests for arm/disarm.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

No changes to configuration.

# Example configuration.yaml

Additional information

• This PR fixes or closes issue: fixes totalconnect provides no user feedback when arming fails #33301
• This PR is related to issue: totalconnect error when arming and no sensor state #33172
• Link to documentation pull request: n/a

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• [n/a] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• [n/a] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[austinmroczek]

Does raising that exception result in feedback to the user in the UI?

…

Sent from my iPhone

On May 26, 2020, at 9:19 AM, J. Nick Koston ***@***.***> wrote:  @bdraco commented on this pull request. In homeassistant/components/totalconnect/alarm_control_panel.py: > @@ -114,16 +116,40 @@ def update(self): def alarm_disarm(self, code=None): """Send disarm command.""" - self._client.disarm(self._location_id) + if self._client.disarm(self._location_id) is not True: + persistent_notification.async_create( Do we need a notification here? Can you instead raise HomeAssistantError(f"TotalConnect failed to disarm {self._name}.") — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[bdraco]

Does raising that exception result in feedback to the user in the UI?

Yes

[austinmroczek]

@bdraco I redid the code like you suggested. I can see the exception being raised in a log entry, but there is no immediate feedback in the user interface. Am I missing something?

[bdraco]

Here is an example of what you should see. This is from doorbird.switch.DoorBirdSwitch:turn_off. The example are from the main UI, and the services dev tools

[MartinHjelmare]

Looks good!