Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONVIF: Add check around media capabilities #35667

Merged
merged 1 commit into from
May 15, 2020
Merged

ONVIF: Add check around media capabilities #35667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions homeassistant/components/onvif/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,13 @@ async def async_get_device_info(self) -> DeviceInfo:

async def async_get_capabilities(self):
"""Obtain information about the available services on the device."""
media_service = self.device.create_media_service()
media_capabilities = await media_service.GetServiceCapabilities()
snapshot = False
try:
media_service = self.device.create_media_service()
media_capabilities = await media_service.GetServiceCapabilities()
snapshot = media_capabilities.SnapshotUri
except (ONVIFError, Fault):
pass

pullpoint = False
try:
Expand All @@ -225,7 +230,7 @@ async def async_get_capabilities(self):
except ONVIFError:
pass

return Capabilities(media_capabilities.SnapshotUri, pullpoint, ptz)
return Capabilities(snapshot, pullpoint, ptz)

async def async_get_profiles(self) -> List[Profile]:
"""Obtain media profiles for this device."""
Expand Down