Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssdp discovery for isy994 #35568

Merged
merged 7 commits into from
May 13, 2020
Merged

Add ssdp discovery for isy994 #35568

merged 7 commits into from
May 13, 2020

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 13, 2020

Proposed change

Add ssdp discovery for isy994

  • Increase test coverage for existing config flow

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

* Increase test coverage for existing config flow
@probot-home-assistant
Copy link

Hey there @shbatm, mind taking a look at this pull request as its been labeled with a integration (isy994) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Contributor

@shbatm shbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Couple minor things.

Will test when I get a chance, but the protocols look like they match the ISY Cookbook.

tests/components/isy994/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/isy994/test_config_flow.py Show resolved Hide resolved
tests/components/isy994/test_config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/isy994/config_flow.py Outdated Show resolved Hide resolved
@shbatm
Copy link
Contributor

shbatm commented May 13, 2020

LGTM! Can't test local discovery on my device based on network conditions, don't see any issues though.

@bdraco bdraco merged commit 6d8b8ec into home-assistant:dev May 13, 2020
@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants