-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add growatt battery devices #34773
Add growatt battery devices #34773
Conversation
FYI, you should not use the term "Storage devices" for batteries because "storage device" most commonly refers to a "data storage device": https://en.wikipedia.org/w/index.php?title=Data_storage_device I believe that the correct terminology is "energy storage" or "home energy storage" as a general term for any type of energy storing devices: https://en.wikipedia.org/wiki/Energy_storage If always specifically only batteries then it technically is "Electrochemical energy storage" where products are today commercially commonly referred to as "Battery Energy Storage System" (or "BESS" for short). https://en.wikipedia.org/wiki/Home_energy_storage Other very common "energy storage" devices for private homes are accumulator which usually store energy as heat (normally hot water), like a hot water storage tank: https://en.wikipedia.org/wiki/Accumulator_(energy) https://en.wikipedia.org/wiki/Hot_water_storage_tank Commercial buildings take accumulators to the next-level, storing both heat and cold, few private homes do that but see: https://www.youtube.com/watch?v=N3Em64OBGqI |
That is fair enough, it can be confusing if context is not clear. I will change the title and description of this PR once i have the time. in code and in context of Growatt and their API it may be more clear to use |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please solve the merge conflict.
…eature/growatt_battery_support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There were some issues caused by the merge, it should be fine now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes to mark the correct status. See above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Proposed change
This PR aims to add battery sensor information to the Growatt server integration. This has been tested on my Home assistant instance with two accounts:
Type of change
Example entry for
configuration.yaml
:Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: