Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mychevy library to 2.0.1 #34496

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Conversation

sdague
Copy link
Contributor

@sdague sdague commented Apr 21, 2020

Proposed change

This fixes authentication issues with the site to handle their
transition to azure based logins.

Changelog: https://github.com/sdague/mychevy/blob/master/HISTORY.rst#201-2020-04-21

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

This fixes authentication issues with the site to handle their
transition to azure based logins.

Fixes home-assistant#33132
@frenck
Copy link
Member

frenck commented Apr 21, 2020

This change essentially changes this integration to make use of web scraping to facilitate the login.

sdague/mychevy@c34dea4#diff-d4dcea6dd608945cca0cfb36b44f28b5R222

This might conflict with ADR-0004:

https://github.com/home-assistant/architecture/blob/master/adr/0004-webscraping.md

PS: Please include a changelog to dependency bumps, I have added it now. That saves a reviewer the search 😉

@sdague
Copy link
Contributor Author

sdague commented Apr 21, 2020

The integration has always required webscraping for the login process to the chevy site. Once that is done it ends up using a json interface. However getting the session information is problematic, there is no API for bootstrapping the auth parts.

@pvizeli
Copy link
Member

pvizeli commented Apr 21, 2020

I see that like @sdague. And it's a json interface not parse stupid html

@frenck
Copy link
Member

frenck commented Apr 21, 2020

@pvizeli Partly agree.
It runs a regular expression on the HTML output to get the JSON from the HTML...

Hence my initial response: "might conflict".

The initial goal of the ADR was to get rid of integrations that scrape the web and break down if the HTML changes. In this case, since it runs a regular expression on the HTML to get the JSON, it will suffer from the same reasoning as to why the ADR was created in the first place.

Edit: No judgment on the PR (not an approval or disapproval from my end).

@balloob
Copy link
Member

balloob commented Apr 22, 2020

I think that this is fine. We should consider putting up an amendment to ADR-004 to exclude requiring login credentials.

@balloob balloob merged commit 7f77e99 into home-assistant:dev Apr 22, 2020
@lock lock bot locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mychevy: KeyError: 'vehicleMap'
5 participants