Arcam config flow #34384
Merged
Arcam config flow #34384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, i've working on resolving some more comments from #29334 |
8 tasks
elupus
force-pushed
the
arcam_config_flow
branch
4 times, most recently
from
895b412 to
614d7f5
Compare
|
I pulled out the device automation code from this pull request, to reduce review size. |
20 tasks
elupus
force-pushed
the
arcam_config_flow
branch
2 times, most recently
from
61ca38a to
d454cf3
Compare
20 tasks
elupus
force-pushed
the
arcam_config_flow
branch
2 times, most recently
from
5e53ec1 to
b9378f2
Compare
bdraco
reviewed
May 25, 2020
bdraco
reviewed
May 25, 2020
bdraco
reviewed
May 25, 2020
| "name": f"{DEFAULT_NAME} ({self._state.client.host})", | ||
| "identifiers": { | ||
| (DOMAIN, self._uuid), | ||
| (DOMAIN, self._state.client.host, self._state.client.port), |
There was a problem hiding this comment.
host and port can change so they aren't stable, so they should likely be removed.
There was a problem hiding this comment.
Yes, we can remove it later. Once people have upgraded. Otherwise we would leave these devices unconnected to entities.
bdraco
requested changes
May 25, 2020
There was a problem hiding this comment.
Nice job on the test coverage
Please see comments above
----------- coverage: platform linux, python 3.8.1-final-0 -----------
Name Stmts Miss Cover Missing
------------------------------------------------------------------------------------
homeassistant/components/arcam_fmj/config_flow.py 77 0 100%
homeassistant/components/arcam_fmj/const.py 10 0 100%
homeassistant/components/arcam_fmj/device_trigger.py 27 1 96% 70
------------------------------------------------------------------------------------
TOTAL 114 1 99%
bdraco
reviewed
May 25, 2020
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: J. Nick Koston <nick@koston.org>
balloob
reviewed
May 27, 2020
balloob
reviewed
May 27, 2020
balloob
reviewed
May 27, 2020
balloob
reviewed
May 27, 2020
balloob
reviewed
May 27, 2020
MartinHjelmare
requested changes
May 27, 2020
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
This completely drops support for YAML based configuration. Remove section from config.
To support turn_on action, you will need to setup an automation based on an exposed event from the integration. This can be accomplished via device actions.
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: