Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rounding the light level conversion in Lutron Caseta #34167

Merged

Conversation

swails
Copy link
Contributor

@swails swails commented Apr 13, 2020

Proposed change

Adjust Home Assistant -> Lutron light level conversion to use rounding instead of simple truncation

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@springstan springstan changed the title Improve rounding behavior for HASS -> Lutron Caseta light level conversions Improve rounding the light level conversion in Lutron Caseta Apr 13, 2020
@springstan springstan merged commit 028e08c into home-assistant:dev Apr 13, 2020
@springstan
Copy link
Member

Going to tag this for 0.108.4 as it is a hotfix for a problem that occurred in 0.108.

@springstan springstan added this to the 0.108.4 milestone Apr 13, 2020
@balloob balloob mentioned this pull request Apr 14, 2020
@lock lock bot locked and limited conversation to collaborators Apr 15, 2020
@balloob balloob added the bugfix label May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

light.turn_on sets incorrect brightness level with Lutron Caseta
4 participants