Convert sense to use DataUpdateCoordinator for trends data #34160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sense was having api performance issue this afternoon. Its not blocking anything now. So should be good to go. |
balloob
reviewed
Apr 13, 2020
|
|
||
| # async_request_refresh instead of async_refresh | ||
| # as this can take longer than 60s | ||
| await trends_coordinator.async_request_refresh() |
There was a problem hiding this comment.
This will still trigger the fetch and block until it is finished.
There was a problem hiding this comment.
Oh nevermind, default debouncer of update coordinator is not set to immediate
There was a problem hiding this comment.
Uuh, I was wrong. It is set to immediate by default. So this is doing a full refresh.
There was a problem hiding this comment.
Thanks. Switched to async_call_later unless you can suggest something better?
balloob
reviewed
Apr 13, 2020
balloob
reviewed
Apr 13, 2020
balloob
approved these changes
Apr 13, 2020
Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>
Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>
|
Retested with changes! TEST PASS Thanks @balloob |
balloob
added a commit
that referenced
this pull request
Apr 14, 2020
* Convert sense to use DataUpdateCoordinator for trends * remove unused * request update right away * clarify * call async refresh later * Update homeassistant/components/sense/__init__.py Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io> * Update homeassistant/components/sense/__init__.py Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io> Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Sense sometimes fails to startup because update_trend_data takes longer than 60 seconds.
Convert sense to use DataUpdateCoordinator for trends data
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: