Removed uncaught exceptions from Dyson #34112
Conversation
probot-home-assistant
bot
added
core
has-tests
integration: dyson
small-pr
| @@ -195,5 +195,5 @@ def __init__(self, device): | |||
| def state(self): | |||
| """Return Air Quality value.""" | |||
| if self._device.environmental_state: | |||
| return int(self._device.environmental_state.volatil_organic_compounds) | |||
There was a problem hiding this comment.
This typo is also in the base lib https://github.com/etheralm/libpurecool/blob/3d8eab13fa9e9d67d215f67d1915bbd88f040527/libpurecool/dyson_pure_state.py#L132
There was a problem hiding this comment.
yes. it appeared in both ways in the tests and apparently it does so also in the library. definitely looks like a library bug since it should be the same interface for v1 and v2
There was a problem hiding this comment.
in any case, it looks like the library maintainer and the component is the same, so he/she can probably shed some more light here
…gs into the mocks so they don't throw exceptions for mocks not being able to convert to int
|
The v1 API implementation was done by the author of the original library (libpurecoollink). I was planing on updating both the library and the home assistant integration for the v1 api devices after I finish the home assistant integration for the HP06 model. |
|
so the current one only supports v1? |
added both values to the mock device (volatil and volatile)
|
ok. reverted the homeassistant/components/dyson to its original state |
Breaking change
not breaking
Proposed change
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: