Split ffmpeg to compoment

[pvizeli]

Description:

I work a new component (openalpr) they also use ffmpeg. We have a lot of ffmpeg device and it's cleaner to have a ffmpeg component and cleanup some duplication in sources.

Now it support cache for tests @balloob

Example entry for configuration.yaml (if applicable):

ffmpeg:
  ffmpeg_bin: /bin/ffmpeg
  run_test: True

Braking stuff
I move the ffmpeg_bin to component it self.

Checklist:

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If code communicates with devices, web services, or a:

• Local tests with tox run successfully. Your PR cannot be merged unless tests pass
• New dependencies have been added to the REQUIREMENTS variable (example).
• New dependencies are only imported inside functions that use them (example).
• New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

[balloob]

You are registering the service binary_sensor/restart. That is very generic. Can you rename it to binary_sensor/ffmpeg_restart

[balloob]

Any reason why binary sensor has a restart service but camera has not ?

[pvizeli]

The service us allready binary_sensor.ffmpeg_restart. I rename only a internal function for better understanding. Camera have a other working conzept from HA. It not run constantly. It take a picture every 10 sec and run if a user is showing on UI until Werkzeug to close the request or a internal timeout is present from (I think) cherrpy. Is that so okay @balloob?

[balloob]

Yes sir!

On Wed, Sep 14, 2016, 22:03 Pascal Vizeli notifications@github.com wrote:

The service us allready binary_sensor.ffmpeg_restart. I rename only a
internal function for better understanding. Camera have a other working
conzept from HA. It not run constantly. It take a picture every 10 sec and
run if a user is showing on UI until Werkzeug to close the request or a
internal timeout is present from (I think) cherrpy. Is that so okay
@balloob https://github.com/balloob?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3396 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYJ2rd48QeSB1dcpi8qmXJ-0j_IDY86ks5qqNGVgaJpZM4J8u_4
.

[dcrypt3d]

Getting some errors from this:

16-09-16 10:27:34 homeassistant.components.camera: Error while setting up platform ffmpeg
Traceback (most recent call last):
  File "/home/user/home-assistant/homeassistant/helpers/entity_component.py", line 107, in _setup_platform
    discovery_info)
  File "/home/user/home-assistant/homeassistant/components/camera/ffmpeg.py", line 32, in setup_platform
    if not run_test(config.get(CONF_INPUT)):
  File "/home/user/home-assistant/homeassistant/components/ffmpeg.py", line 56, in run_test
    if FFMPEG_CONFIG.get(CONF_RUN_TEST):
AttributeError: 'NoneType' object has no attribute 'get'

[pvizeli]

I've create a bugfix PR. Can you try to test this?

Am 16.09.2016 4:31 PM schrieb "devdelay" notifications@github.com:

Getting some errors from this:

File "/home/user/home-assistant/homeassistant/components/camera/ffmpeg.py", line 32, in setup_platform
File "/home/user/home-assistant/homeassistant/components/ffmpeg.py", line 56, in run_test

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#3396 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOoMLI1E84qnKPtc_mlPlJc69jgSUaL8ks5qqqg-gaJpZM4J8u_4
.