Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use voluptuous for Zone #3377

Merged
merged 2 commits into from
Sep 14, 2016
Merged

Use voluptuous for Zone #3377

merged 2 commits into from
Sep 14, 2016

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Sep 13, 2016

Description:
Migration of the configuration check to voluptuous.

Related issue (if applicable): fixes 127528299

Example entry for configuration.yaml (if applicable):

zone:
  name: School
  latitude: 32.8773367
  longitude: -117.2494053
  radius: 250
  icon: mdi:school

zone 2:
  name: Work
  latitude: 32.8753367
  longitude: -117.2474053

It would be nice if somebody could take a look at the changes and run a quick test. Thanks.

@fabaff fabaff mentioned this pull request Sep 13, 2016
@balloob balloob merged commit 782838a into home-assistant:dev Sep 14, 2016
@dcrypt3d
Copy link
Contributor

Something not right with this. Getting an "expected a dictionary for dictionary value" error.

@balloob balloob mentioned this pull request Sep 16, 2016
2 tasks
@balloob
Copy link
Member

balloob commented Sep 16, 2016

Fixed it in #3413

hartmms pushed a commit to hartmms/home-assistant that referenced this pull request Sep 17, 2016
* Migrate to voluptuous

* Zone: Remove unneeded latitude/longitude check
@fabaff fabaff deleted the voluptuous-zone branch September 22, 2016 07:30
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants