Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use voluptuous for KNX #3345

Merged
merged 2 commits into from
Sep 14, 2016
Merged

Use voluptuous for KNX #3345

merged 2 commits into from
Sep 14, 2016

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Sep 12, 2016

Description:
Migration of the configuration check to voluptuous. This is a breaking change as http:// will no longer be needed for the host: configuration variable. Not sure if itunes-api supports SSL/TLS.

Related issue (if applicable): fixes 127528299

Example entry for configuration.yaml (if applicable):

knx:
  host: IP_ADDRESS
  port: PORT

switch:
  - platform: knx
    name: KNX Switch
    address: 0/0/1
    state_address: 0/0/3

@usul27 @open-homeautomation
, would be nice if you could take a look at the changes and run a quick test. Thanks.

@fabaff fabaff mentioned this pull request Sep 12, 2016
Closed
ghost
ghost reviewed Sep 12, 2016
View reviewed changes
homeassistant/components/knx.py
_LOGGER = logging.getLogger(__name__)
CONFIG_SCHEMA = vol.Schema({
DOMAIN: vol.Schema({
vol.Required(CONF_HOST): cv.string,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be optional with a default value of 0.0.0.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback. I will change it.

@balloob balloob merged commit 727b756 into home-assistant:dev Sep 14, 2016
@fabaff fabaff deleted the voluptuous-knx branch September 16, 2016 08:40
hartmms pushed a commit to hartmms/home-assistant that referenced this pull request Sep 17, 2016
@fabaff @hartmms
Use voluptuous for KNX (home-assistant#3345)
fba6a4c 
* Migrate to voluptuous

* Make host optional and set default
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
voluptuous
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabaff @balloob