Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with smhi-pkg #33248

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Fix issue with smhi-pkg #33248

merged 2 commits into from
Mar 25, 2020

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Mar 25, 2020

Breaking change

Proposed change

Strange packages and no one knows who is responsible...

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label Mar 25, 2020
@frenck
Copy link
Member

frenck commented Mar 25, 2020

The root cause is the publication of a Python wheel:

image

However, the wheel is empty @helto4real...

image

@balloob balloob merged commit 6990c70 into dev Mar 25, 2020
@balloob balloob deleted the smhi-ci branch March 25, 2020 16:19
@helto4real
Copy link
Contributor

helto4real commented Mar 25, 2020

I will fix it
ALot of swedish users use that integration.

@helto4real
Copy link
Contributor

helto4real commented Mar 25, 2020

There is a new version of the lib 1.0.12, hope that should be fine.
[take that back] There is smthe screwed up with my build system]

pvizeli added a commit that referenced this pull request Mar 25, 2020
pvizeli added a commit that referenced this pull request Mar 25, 2020
* Revert "Fix issue with smhi-pkg (#33248)"

This reverts commit 6990c70.

* Bump version to 1.0.13
@lock lock bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants