Fix input text reload #32911
Merged
Fix input text reload #32911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
core
integration: input_text
small-pr
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
balloob
approved these changes
Mar 17, 2020
balloob
reviewed
Mar 17, 2020
| @@ -294,5 +294,12 @@ def state_attributes(self): | |||
|
|
|||
| async def async_update_config(self, config: typing.Dict) -> None: | |||
| """Handle when the config is updated.""" | |||
| # set defaults for empty config | |||
| config = { | |||
There was a problem hiding this comment.
I wonder if the better fix here is to just run it through the voluptuous schema again?
Should this be done for all the other input_* too?
balloob
approved these changes
Mar 17, 2020
balloob
pushed a commit
that referenced
this pull request
Mar 18, 2020
* Fix input text reload * FIx schema instead
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Fixes #32879
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: