Get pending iCloud devices when available + request again when needs an update #32400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
Quentame
force-pushed
the
icloud/retry-if-pending
branch
from
26577d1 to
7ced2c9
Compare
Quentame
force-pushed
the
icloud/retry-if-pending
branch
from
7ced2c9 to
5f2b967
Compare
balloob
reviewed
Mar 4, 2020
balloob
reviewed
Mar 4, 2020
|
@balloob Can we add this to 0.106.6 since the bug is coming from 0.104.0 ? |
balloob
reviewed
Mar 5, 2020
|
I'm fine with adding this to 106.6, I however don't know when it will be released. |
balloob
reviewed
Mar 5, 2020
balloob
approved these changes
Mar 5, 2020
balloob
pushed a commit
that referenced
this pull request
Mar 10, 2020
…an update (#32400) * Fetch iCloud devices again if the status is pending * Remove "No iCloud device found" double check * fix default api_devices value * Remove useless unitialisation declarations
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fetch devices again when retrieved devices are in pending status + add devices that was not added at first setup because can't be reached (most of the time : off laptop or family devices).
It is actually causing a bug while battery status and location are not updated for hours (thanks to less fetching the iCloud API) !!!
Issue #32303, bug from 0.104.0
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: