Add BSBLan Climate integration #32375

liudger · 2020-03-01T12:45:03Z

The most basic climate functions work.

Breaking change

Proposed change

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Example entry for `configuration.yaml`:

# Example configuration.yaml

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request: add bsblan documentation home-assistant.io#12241

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

No score or internal
🥈 Silver
🥇 Gold
🏆 Platinum

homeassistant · 2020-03-01T12:45:06Z

Hi @liudger,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant · 2020-03-01T12:46:30Z

Hi @liudger,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

liudger · 2020-03-02T15:33:44Z

Hey Frenck, how are you doing?

I am currently working on the documentation. I cloned the docs and now reading the howto.
As you can see I borrowed the base template of elgato keylight (after watching the youtube about creating an integration from scratch). So I hope the code is not too shabby. If you have any recommendations let me know.

regards WJ

ps I saw there was a tage from here_travel_time. That is an incorrect tag.

liudger · 2020-03-02T20:31:11Z

I added the doc in a pull request
home-assistant/home-assistant.io#12241
How do I exclude the bsblan code from coverage? Is there a command or just manually add to the .coverage file?

BudBundi · 2020-04-02T19:03:46Z

Is there any reason, this PR is not merged yet?
The custom component is broken for a long time, so a can't wait to test this new component.

liudger · 2020-04-05T08:51:30Z

I am not sure what the progress is. But it looks like someone needs to review the code. I am already working on the next release and I hope that incremental updates will go faster after the initial release.

.coveragerc

homeassistant/components/bsblan/__init__.py

homeassistant/components/bsblan/climate.py

homeassistant/components/bsblan/const.py

homeassistant/components/bsblan/manifest.json

homeassistant/components/bsblan/strings.json

homeassistant/components/bsblan/climate.py

The most basic climate functions work.

wrongly added to commit

current_hvac_mode

include passkey and added some more for device indentification

also added passkey

liudger · 2020-05-07T16:53:57Z

Hi Martin,

I got another question. The bsblan device is the device that is in-between the heatpump/heating System and homeassistant integration. When I want to collect device properties like

manufacturer | The manufacturer of the device.
model | The model of the device.
config_entries | Config entries that are linked to this device.
sw_version | The firmware version of the device.

Should I collect this info from the heating system or should it be the bsblan device info? The bsblan device can control multiple heating systems so the heating system is the entity?
So than I should collect it from bsbland device? but that is quite boring and lot of info is not available for this device. Manufacturer is probably the user himself? So I am a bit confused. Also now the climatedevice is renamed to climate entity. and in the docs we are talking about the device to collect these info from.

Thanks and hopefully we are almost done:)

regards Willem-Jan

homeassistant/components/bsblan/climate.py

MartinHjelmare · 2020-05-07T20:20:13Z

We could create a device in the base integration module representing the bsblan device and then have the device_info properties in the entities represent each connected heating system. Bind the devices together with the via_device attribute:

https://developers.home-assistant.io/docs/device_registry_index#device-properties

https://developers.home-assistant.io/docs/device_registry_index#defining-devices

This is done in the configflow

liudger · 2020-05-07T20:32:10Z

Shall we leave the via_device for the next release? I'll look into it. Overlooked it on my frist pass

MartinHjelmare

Just some small fixes remaining.

homeassistant/components/bsblan/strings.json

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

MartinHjelmare

Great!

probot-home-assistant bot added integration: here_travel_time new-integration integration: bsblan labels Mar 1, 2020

homeassistant added the cla-needed label Mar 1, 2020

This comment has been minimized.

Sign in to view

homeassistant added cla-signed and removed cla-needed labels Mar 1, 2020

This comment has been minimized.

Sign in to view

frenck added the docs-missing label Mar 2, 2020

liudger mentioned this pull request Mar 3, 2020

add bsblan documentation home-assistant/home-assistant.io#12241

Merged

7 tasks

liudger changed the title ~~Initial commit for BSBLan Climate component~~ Initial commit for BSBLan Climate integration Mar 3, 2020

liudger force-pushed the bsblan-component branch from 81b6519 to 704499c Compare March 3, 2020 16:13

springstan removed the docs-missing label Mar 9, 2020

springstan changed the title ~~Initial commit for BSBLan Climate integration~~ Add BSBLan Climate integration Mar 9, 2020

MartinHjelmare requested changes Apr 16, 2020

View reviewed changes

MartinHjelmare removed the integration: here_travel_time label Apr 16, 2020

liudger force-pushed the bsblan-component branch 2 times, most recently from 4101d01 to ac3ee44 Compare April 18, 2020 08:57

MartinHjelmare self-assigned this Apr 19, 2020

liudger force-pushed the bsblan-component branch from ac3ee44 to 82e492b Compare May 1, 2020 21:18

MartinHjelmare reviewed May 2, 2020

View reviewed changes

homeassistant/components/bsblan/climate.py Outdated Show resolved Hide resolved

liudger added 3 commits May 6, 2020 22:50

Initial commit for BSBLan Climate component

66f89f8

The most basic climate functions work.

Delete manifest 2.json

c85e9a2

wrongly added to commit

fix incorrect name

0bb234e

current_hvac_mode

liudger added 12 commits May 6, 2020 22:50

Update constants

a921136

include passkey and added some more for device indentification

add passkey for configflow

b14e991

Fix use discovery_info instead of user_input

5076b88

also added passkey

Fix name

08801bf

Fix for discovery_info[CONF_PORT] is None

3519d21

Fix get value CONF_PORT

664003d

Fix move translation to new location

82af844

Fix get the right info

5407eb2

Fix remove zeroconf and fix the code

b3c8c07

Add init for mockConfigEntry

963f319

Fix removed zeroconfig and fix code

25d448b

Fix changed ClimateDevice to ClimatEntity

8fced7c

liudger force-pushed the bsblan-component branch from ff953e8 to 8fced7c Compare May 6, 2020 20:57

Fix log error message

1709772

liudger requested a review from MartinHjelmare May 6, 2020 20:59

liudger added 2 commits May 6, 2020 23:16

Removed debug code

5a251ef

Change name of device.

880b4fa

MartinHjelmare reviewed May 7, 2020

View reviewed changes

homeassistant/components/bsblan/climate.py Outdated Show resolved Hide resolved

Remove check

9b94044

This is done in the configflow

Remove period from logging message

d39fe08

MartinHjelmare reviewed May 7, 2020

View reviewed changes

homeassistant/components/bsblan/strings.json Outdated Show resolved Hide resolved

homeassistant/components/bsblan/strings.json Show resolved Hide resolved

liudger and others added 2 commits May 7, 2020 23:20

Update homeassistant/components/bsblan/strings.json

251d77c

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

Add passkey

8027f6e

MartinHjelmare approved these changes May 7, 2020

View reviewed changes

cgarwood merged commit cf30895 into home-assistant:dev May 10, 2020

liudger deleted the bsblan-component branch May 13, 2020 19:12

lock bot locked and limited conversation to collaborators May 20, 2020

Uh oh!

Add BSBLan Climate integration #32375

Add BSBLan Climate integration #32375

Uh oh!

Conversation

liudger commented Mar 1, 2020 • edited by MartinHjelmare Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking change

Proposed change

Type of change

Example entry for configuration.yaml:

Additional information

Checklist

Uh oh!

homeassistant commented Mar 1, 2020

Uh oh!

This comment has been minimized.

homeassistant commented Mar 1, 2020

Uh oh!

This comment has been minimized.

liudger commented Mar 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liudger commented Mar 2, 2020

Uh oh!

BudBundi commented Apr 2, 2020

Uh oh!

liudger commented Apr 5, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

liudger commented May 7, 2020

Uh oh!

Uh oh!

MartinHjelmare commented May 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liudger commented May 7, 2020

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

liudger commented Mar 1, 2020 •

edited by MartinHjelmare

Loading

Example entry for `configuration.yaml`:

liudger commented Mar 2, 2020 •

edited

Loading

MartinHjelmare commented May 7, 2020 •

edited

Loading