Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: keep looking for new devices #3201

Merged
merged 4 commits into from
Sep 6, 2016
Merged

Bluetooth: keep looking for new devices #3201

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
038f29a
keep looking for new devices
Bart274 Sep 5, 2016
3920a11
Update bluetooth_tracker.py
Bart274 Sep 5, 2016
694a82c
change default value for tracking new devices
Bart274 Sep 5, 2016
9a506c5
remove commented code
Bart274 Sep 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
keep looking for new devices
  • Loading branch information
@Bart274
Bart274 authored Sep 5, 2016
commit 038f29abcb105d5504c271a09756d332f1daf298
11 changes: 8 additions & 3 deletions homeassistant/components/device_tracker/bluetooth_tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,20 @@ def discover_devices():
devs_to_track.append(dev[0])
see_device(dev)

if not devs_to_track:
_LOGGER.warning("No bluetooth devices to track!")
return False
# if not devs_to_track:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not leave commented code in the repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the code, I removed it :)

# _LOGGER.warning("No bluetooth devices to track!")
# return False

interval = config.get(CONF_SCAN_INTERVAL, DEFAULT_SCAN_INTERVAL)

def update_bluetooth(now):
"""Lookup bluetooth device and update status."""
try:
if track_new:
for dev in discover_devices():
if dev[0] not in devs_to_track and \
dev[0] not in devs_donot_track:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

farcy v1.1

  • 5: E125 continuation line with same indent as next logical line

devs_to_track.append(dev[0])
for mac in devs_to_track:
_LOGGER.debug("Scanning " + mac)
result = bluetooth.lookup_name(mac, timeout=5)
Expand Down