Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shutter group to HomematicIP Cloud #31916

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Add shutter group to HomematicIP Cloud #31916

merged 1 commit into from
Feb 19, 2020

Conversation

SukramJ
Copy link
Contributor

@SukramJ SukramJ commented Feb 17, 2020

Proposed change

Add shutter group to HomematicIP Cloud

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #31916 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31916      +/-   ##
==========================================
+ Coverage   94.69%   94.69%   +<.01%     
==========================================
  Files         763      763              
  Lines       55183    55193      +10     
==========================================
+ Hits        52255    52265      +10     
  Misses       2928     2928
Impacted Files Coverage Δ
...omeassistant/components/homematicip_cloud/cover.py 100% <100%> (ø) ⬆️
homeassistant/bootstrap.py 72.78% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2366b5f...3259778. Read the comment docs.

Copy link
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@SukramJ SukramJ mentioned this pull request Feb 19, 2020
20 tasks
@springstan
Copy link
Member

@SukramJ please update the documentation accordingly :)

@SukramJ
Copy link
Contributor Author

SukramJ commented Feb 19, 2020

Groups are not documented for HomematicIP Cloud (same as hue, doconz), so there is no open task, and i think this is not required. But thanks for taking care of it.

@springstan springstan merged commit 0d87490 into home-assistant:dev Feb 19, 2020
@SukramJ SukramJ deleted the HmIP-SlatsGroup branch February 19, 2020 10:00
@SukramJ SukramJ mentioned this pull request Feb 19, 2020
20 tasks
@lock lock bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants