Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Assistant: Remove speaker type and earlier filter out devices from being locally exposed #31830

Merged
merged 2 commits into from
Feb 14, 2020

Conversation

balloob
Copy link
Member

@balloob balloob commented Feb 14, 2020

Proposed change

Some fixes for certification:

  • Filter out devices that might 2FA for local SDK in SYNC response instead of REACHABLE_DEVICES response
  • Filter out locks and alarm panels for local exposure based on type
  • Remove speaker type because it's only for built-in speakers

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration (google_assistant) you are listed as a codeowner for? Thanks!

@balloob balloob added this to the 0.105.4 milestone Feb 14, 2020
@balloob balloob changed the title Remove speaker type Google Assistant: Remove speaker type and earlier filter out devices from being locally exposed Feb 14, 2020
@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #31830 into dev will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31830      +/-   ##
==========================================
- Coverage   94.67%   94.66%   -0.02%     
==========================================
  Files         763      763              
  Lines       55148    55167      +19     
==========================================
+ Hits        52214    52223       +9     
- Misses       2934     2944      +10
Impacted Files Coverage Δ
...ssistant/components/google_assistant/smart_home.py 91.2% <ø> (ø) ⬆️
...meassistant/components/google_assistant/helpers.py 93.87% <100%> (+0.07%) ⬆️
homeassistant/components/google_assistant/const.py 100% <100%> (ø) ⬆️
...meassistant/components/homematicip_cloud/switch.py 93.4% <0%> (-6.6%) ⬇️
...eassistant/components/homematicip_cloud/climate.py 98.29% <0%> (-1.71%) ⬇️
...omponents/homematicip_cloud/alarm_control_panel.py 98.52% <0%> (-1.48%) ⬇️
...omeassistant/components/homematicip_cloud/cover.py 97.36% <0%> (-1.32%) ⬇️
homeassistant/components/ipma/config_flow.py 100% <0%> (ø) ⬆️
...stant/components/homekit_controller/config_flow.py 100% <0%> (ø) ⬆️
homeassistant/components/coolmaster/config_flow.py 100% <0%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebeab7f...fedd365. Read the comment docs.

@elupus
Copy link
Contributor

elupus commented Feb 14, 2020

Could you elaborate what you mean by "built in speakers". I don't mind the change since is unofficial anyway, just wanted to know where you might have gotten the insight.

@elupus
Copy link
Contributor

elupus commented Feb 14, 2020

Ps.. so odd that action.devices.types.YOGURTMAKER is official, but not any for a normal stereo :)

@balloob
Copy link
Member Author

balloob commented Feb 14, 2020

Google told us :-)

@balloob balloob merged commit 4501471 into dev Feb 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the google-fixes branch February 14, 2020 23:28
balloob added a commit that referenced this pull request Feb 14, 2020
…from being locally exposed (#31830)

* Remove speaker type

* Do not expose locks or alarms to Google Local
@balloob balloob mentioned this pull request Feb 14, 2020
@lock lock bot locked and limited conversation to collaborators Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants