-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Assistant: Remove speaker type and earlier filter out devices from being locally exposed #31830
Conversation
Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration ( |
Codecov Report
@@ Coverage Diff @@
## dev #31830 +/- ##
==========================================
- Coverage 94.67% 94.66% -0.02%
==========================================
Files 763 763
Lines 55148 55167 +19
==========================================
+ Hits 52214 52223 +9
- Misses 2934 2944 +10
Continue to review full report at Codecov.
|
Could you elaborate what you mean by "built in speakers". I don't mind the change since is unofficial anyway, just wanted to know where you might have gotten the insight. |
Ps.. so odd that action.devices.types.YOGURTMAKER is official, but not any for a normal stereo :) |
Google told us :-) |
…from being locally exposed (#31830) * Remove speaker type * Do not expose locks or alarms to Google Local
Proposed change
Some fixes for certification:
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: