Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix person device_trackers null #31829

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Fix person device_trackers null #31829

merged 1 commit into from
Feb 14, 2020

Conversation

balloob
Copy link
Member

@balloob balloob commented Feb 14, 2020

Breaking change

Proposed change

If a person has onboarded before we migrated person integration to the new collection helper, we accidentally had written device_trackers as None. It should always be a list. Some people fixed this for themselves by mutating person via the config UI, for the rest, this will fix it.

This should fix errors people experience with registering a mobile app.

Fixes #31816

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@balloob balloob merged commit 52b045e into dev Feb 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-person-create branch February 14, 2020 23:27
balloob added a commit that referenced this pull request Feb 14, 2020
@balloob balloob mentioned this pull request Feb 14, 2020
@lock lock bot locked and limited conversation to collaborators Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registering mobile app causes error in person integration
3 participants