Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migrating huawei_lte entry without recipient #31522

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

chmielowiec
Copy link
Contributor

Proposed change

Fixes migration of huawei_lte #31508

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @scop, mind taking a look at this pull request as its been labeled with a integration (huawei_lte) you are listed as a codeowner for? Thanks!

@MartinHjelmare MartinHjelmare changed the title Fixed migrating entry without recipient Fix migrating huawei_lte entry without recipient Feb 6, 2020
Copy link
Member

@scop scop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@scop scop merged commit 24e9a63 into home-assistant:dev Feb 6, 2020
@balloob balloob added this to the 0.105.2 milestone Feb 6, 2020
@balloob balloob mentioned this pull request Feb 6, 2020
@lock lock bot locked and limited conversation to collaborators Feb 8, 2020
@chmielowiec chmielowiec deleted the patch-1 branch February 14, 2020 22:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error migrating entry B715s-23c for huawei_lte
4 participants