-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webostv sound_output capability #31121
Conversation
Add the ability to read and set the sound_output
@bendavid could you have a look at this PR and make suggestions or approve it? |
This looks fine to me. If maintainers are picky about such things it might be worth squashing the commit history, but I don't have strong feelings about this myself. |
Do not have the ability to test this change right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Test failure is unrelated. Merging. |
@MartinHjelmare thanks! |
Proposed change
Add the ability to read and set the sound_output
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: