-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Salt Fiber Box device tracker #30986
Merged
MartinHjelmare
merged 15 commits into
home-assistant:dev
from
bjornorri:salt_device_tracker
Feb 2, 2020
Merged
Add Salt Fiber Box device tracker #30986
MartinHjelmare
merged 15 commits into
home-assistant:dev
from
bjornorri:salt_device_tracker
Feb 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornorri
changed the title
Implement Salt Fiber Box device tracker
Salt Fiber Box device tracker
Jan 19, 2020
2 tasks
bjornorri
force-pushed
the
salt_device_tracker
branch
from
January 19, 2020 21:31
0c9489c
to
c9e86d5
Compare
springstan
changed the title
Salt Fiber Box device tracker
Add Salt Fiber Box device tracker
Jan 20, 2020
bjornorri
requested review from
fabaff
and removed request for
MartinHjelmare and
fabaff
January 21, 2020 11:22
elupus
reviewed
Jan 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not at all up to date on device trackers, so just consider this some minor review.
springstan
reviewed
Feb 1, 2020
Co-Authored-By: springstan <46536646+springstan@users.noreply.github.com>
bjornorri
force-pushed
the
salt_device_tracker
branch
from
February 2, 2020 13:10
23ea189
to
3f9c1bd
Compare
MartinHjelmare
requested changes
Feb 2, 2020
MartinHjelmare
approved these changes
Feb 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implements a device_tracker platform for the Salt Fiber Box. Salt is a Swiss internet provider.
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11811
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: