Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Salt Fiber Box device tracker #30986

Merged
merged 15 commits into from
Feb 2, 2020

Conversation

bjornorri
Copy link
Contributor

@bjornorri bjornorri commented Jan 19, 2020

Description:

Implements a device_tracker platform for the Salt Fiber Box. Salt is a Swiss internet provider.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11811

Example entry for configuration.yaml (if applicable):

device_tracker:
  - platform: salt
    password: YOUR_PASSWORD

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@bjornorri bjornorri changed the title Implement Salt Fiber Box device tracker Salt Fiber Box device tracker Jan 19, 2020
@bjornorri bjornorri force-pushed the salt_device_tracker branch from 0c9489c to c9e86d5 Compare January 19, 2020 21:31
@springstan springstan changed the title Salt Fiber Box device tracker Add Salt Fiber Box device tracker Jan 20, 2020
@bjornorri bjornorri requested review from fabaff and removed request for MartinHjelmare and fabaff January 21, 2020 11:22
Copy link
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not at all up to date on device trackers, so just consider this some minor review.

homeassistant/components/salt/device_tracker.py Outdated Show resolved Hide resolved
homeassistant/components/salt/device_tracker.py Outdated Show resolved Hide resolved
homeassistant/components/salt/device_tracker.py Outdated Show resolved Hide resolved
homeassistant/components/salt/manifest.json Outdated Show resolved Hide resolved
homeassistant/components/salt/device_tracker.py Outdated Show resolved Hide resolved
homeassistant/components/salt/device_tracker.py Outdated Show resolved Hide resolved
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@MartinHjelmare MartinHjelmare merged commit 8852cd0 into home-assistant:dev Feb 2, 2020
@lock lock bot locked and limited conversation to collaborators Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants