Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hidden property from fibaro integration #30730

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Conversation

frenck
Copy link
Member

@frenck frenck commented Jan 13, 2020

Breaking Change:

Entities from the Fibaro integration were hidden in Home Assistant if they were hidden in Fibaro, which is no longer the case. This could affect automations that relies on the hidden state attribute of entities created by this integration.

Description:

Removes the hidden property from the Fibaro integration.

The hidden property dates from the pre-Lovelace era, where entities themselves determined if they were hidden or not. Besides, a device hidden in Fibaro, could be shown in the Home Assistant UI, which this change allows for now.

(recap: A device hidden in Fibaro, should not be the control on if a device is shown/hidden in Home Assistant).

Pull request with documentation for home-assistant.io (if applicable): n/a

Example entry for configuration.yaml (if applicable):

fibaro:
  gateways:
    - url: http://192.168.1.161/api/
      username: your_username
      password: your_password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@MartinHjelmare
Copy link
Member

Hidden is part of the entity state attributes if true, so we should mark this a breaking change.

@frenck
Copy link
Member Author

frenck commented Jan 13, 2020

Added breaking change section.

@springstan springstan merged commit 7143ed7 into dev Jan 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the frenck-2020-0073 branch January 13, 2020 13:23
@lock lock bot locked and limited conversation to collaborators Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants