Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hidden property from egardia integration #30728

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Conversation

frenck
Copy link
Member

@frenck frenck commented Jan 13, 2020

Breaking Change:

Binary sensors for the Egardia integration were hidden by default, which is no longer the case. This could affect automations that relies on the hidden state attribute of entities created by this integration.

Description:

Binary sensors for the Egardia integration were hidden by default.

Comment in the original code:

these type of sensors are probably mainly used for automations

This is clearly from the era before Lovelace.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@probot-home-assistant
Copy link

Hey there @jeroenterheerdt, mind taking a look at this pull request as its been labeled with a integration (egardia) you are listed as a codeowner for? Thanks!

@springstan springstan merged commit c8a52d4 into dev Jan 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the frenck-2020-0070 branch January 13, 2020 13:22
@lock lock bot locked and limited conversation to collaborators Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants