Fix HomeKit with entity registry restoration where supported_features is a non-None falsey #30657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Whilst trying to recreate #30638 i managed to write some unit tests that trigger the same exception. I don't think they are the root cause of that ticket but I thought it was weird that
supported_features
could beNone
- the restoration PR set it to 0 in a bunch of places. So this PR will propagate "falsies" that aren't None from the entity registry to the unavailable state. This fixessupported_features
getting set as None instead of 0 (which is a valid value and should be allowed to be part of the state).This includes a bunch of tests to make sure that HomeKit does handle states restored from the entity registry, including e.g. where no value for
supported_features
exists in the entity registry.Related: #30638 #30094
CC @balloob
Checklist:
tox
. Your PR cannot be merged unless tests pass