Set body size for Proxy / streams to 16mb #30608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
core
integration: http
small-pr
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
frenck
approved these changes
Jan 9, 2020
There was a problem hiding this comment.
✅ This will solve a lot of issues with Ingress applications that support file upload or use larger bodies (e.g., large Node-RED flows).
I just wonder if we need to handle the exception thrown by this better, e.g., catching the HTTPRequestEntityTooLarge raised if the request body exceeds this?
|
The |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With all the Proxy code inside (Ingress / API proxy) + the audio handling and video, we need to update the max size from 1mb to 16MB. I see no issue to do that and allow bigger junks to stream.
According: home-assistant/supervisor#1423