Cleanup of state handling in webostv #30416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
has-tests
integration: webostv
small-pr
MartinHjelmare
approved these changes
Jan 3, 2020
|
Looks good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Entity will have STATE_ON when tv is on instead of STATE_PLAYING or STATE_PAUSED as was previously the case. Users will need to update automations that depend on entity state.
Description:
Now that the tv state is updated with asynchronous callbacks, there is no need to directly manipulate the state variables when calling commands. Since the currently known methods cannot distinguish between play and pause states, and the pause command anyways acts as a play-pause toggle, the state handling is further simplified by replacing STATE_PLAYING/STATE_PAUSED with simply STATE_ON, with the advantage that it is no longer possible to go out of sync with the actual state of the tv.