Contributing: Add note about feature suggestions and bug tracking #30225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @andygrunwald, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
springstan
approved these changes
Dec 29, 2019
fabaff
approved these changes
Dec 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding a note to
CONTRIBUTING.mdabout Feature suggestions.In #30195 I wrote down details about an implementation of a new integration.
#30195 was meant to be like a Home Assistant Enhancement Proposal like described in https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#best-practices-for-faster-reviews (linked from the
CONTRIBUTING.md).For me, as a potential new contributor, this was not clear.
I thought it would be useful to write down details, gather community feedback and requirements, before starting with the implementations. More meant to be a design discussion.
This additional note should make it more clear.
Related issue (if applicable): fixes #30195
Checklist:
tox. Your PR cannot be merged unless tests pass