Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Netatmo integration #29851

Merged
merged 58 commits into from
Jan 11, 2020

Conversation

cgtobi
Copy link
Contributor

@cgtobi cgtobi commented Dec 11, 2019

Breaking Change:

A lot

  • for authentication only client id and secret are required, no need to pass your username and password anymore
  • public weather sensors are removed and will be added back in a separate PR
  • Service set_schedule now requires the name of the home
  • webhooks are removed and will be added back in a separate PR
  • Services to toggle the light/set it to auto have been removed until implemented in pyatmo

User with existing configuration have to remove/update that and run the config flow dialogue to get their sensors/etc. back using the configuration.yaml option.

Description:

  • Implements OAuth2 account linking
  • Fixed set_schedule, now requires the name of the home

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11770

Example entry for configuration.yaml (if applicable):

netatmo:
  client_id: your_client_id
  client_secret: your_client_secret

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@cgtobi cgtobi force-pushed the refactor_netatmo_integration branch from c069070 to 62b6bfd Compare January 9, 2020 21:34
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final comment I think.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cgtobi
Copy link
Contributor Author

cgtobi commented Jan 10, 2020

Copy and pasting your suggestions wasn't that hard. 😉

@MartinHjelmare MartinHjelmare merged commit e793ed9 into home-assistant:dev Jan 11, 2020
@MartinHjelmare
Copy link
Member

I missed a docs PR. Please link it in the description.

@cgtobi
Copy link
Contributor Author

cgtobi commented Jan 11, 2020

That is true, I’ll fix that ASAP.

@lock lock bot locked and limited conversation to collaborators Jan 12, 2020
@cgtobi cgtobi deleted the refactor_netatmo_integration branch August 25, 2020 05:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants