-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Netatmo integration #29851
Refactor Netatmo integration #29851
Conversation
c069070
to
62b6bfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of lines are missing coverage in the config flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final comment I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Copy and pasting your suggestions wasn't that hard. 😉 |
I missed a docs PR. Please link it in the description. |
That is true, I’ll fix that ASAP. |
Breaking Change:
A lot
client id and secret
are required, no need to pass your username and password anymoreset_schedule
now requires the name of the homeUser with existing configuration have to remove/update that and run the config flow dialogue to get their sensors/etc. back using the
configuration.yaml
option.Description:
set_schedule
, now requires the name of the homeRelated issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11770
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: