WIP: Split bootstrap into validation, requirements and setup #2912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _LOGGER.error( | ||
| 'Not initializing %s because not all dependencies loaded: %s', | ||
| domain, ", ".join(missing_deps)) | ||
| return False |
There was a problem hiding this comment.
Please return None instead of False.
3 tasks
|
Any update on this one ? |
|
I've extracted the component config validation in #3002. |
|
Hi, been working on this but not finished yet. Validated config cannot always return lists, since it breaks things like groups. Was wondering if I should remove the list if it contains only a single item. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
WIP to split bootstrap into specific functions (documented in comments in the code line 291 onward)