Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow preset boost for Homematic IP Cloud power switches #28713

Merged
merged 4 commits into from
Nov 12, 2019
Merged

Allow preset boost for Homematic IP Cloud power switches #28713

merged 4 commits into from
Nov 12, 2019

Conversation

SukramJ
Copy link
Contributor

@SukramJ SukramJ commented Nov 12, 2019

Description:

This PR allows preset boost for Homematic IP Cloud power switches

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@SukramJ
Copy link
Contributor Author

SukramJ commented Nov 12, 2019

Hi @MartinHjelmare could you please have a look at this PR.
I missed this in my last PR.

MartinHjelmare
MartinHjelmare approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit e834822 into home-assistant:dev Nov 12, 2019
@SukramJ
Copy link
Contributor Author

SukramJ commented Nov 12, 2019

Thanks a lot @MartinHjelmare

@SukramJ SukramJ deleted the HmIP-PowerClimate branch November 12, 2019 10:34
pull bot pushed a commit to KoHcoJlb/home-assistant that referenced this pull request Nov 12, 2019
@SukramJ @pull
Allow preset boost for Homematic IP Cloud power switches (home-assist…
7a15146 
…ant#28713)

* Allow preset boost for Homematic IP Cloud  power switches

* Sort Imports

* Add test

* align test data
@lock lock bot locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed core has-tests integration: homematicip_cloud small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SukramJ @MartinHjelmare @homeassistant