-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More generic use of up and down commands plus a workaround for SOMFY controller. #2852
Conversation
Up functions but not lowering the shades. Also, I messaged you this before, but I'm not sure the purpose of greying both buttons out? Somfy zwave doesn't track state so it's not possible to see the position of the shades at the controller/zwave level. If the buttons weren't greyed out then it would be perfect. Thanks |
We are using the INC(Increment) command to open which equals UP or OPEN |
100 for closed, 0 for open. |
That means level reporting is present. Looking at your zwcfg, all are at 99 which will be reported as 0, Open.https://github.com/turbokongen/home-assistant/blob/zwave_fixes/homeassistant/components/rollershutter/zwave.py#L77 |
5c75f9a
to
ea17b75
Compare
By the look of it then, it works like it should? |
ea17b75
to
b204c82
Compare
I am running 0.25.2 now, it was not functional in 0.26.2. I don't think both buttons are ever greyed out, the problem is sometimes it does not respond to the command because the state isn't matching. |
@jsg4: that particular issue is already fixed in a PR I submitted here home-assistant/frontend#85 but haven't received a response yet. |
e0e8de3
to
fc49c59
Compare
fe60bab
to
f90b364
Compare
@nunofgs Does everything work as normal with this PR? |
So this has now been tested with the Somfy zrtsi which is a zwave to rf controller. Thank you @jsg4. |
@turbokongen you can merge this when you see fit |
812cd24
to
e07df5a
Compare
e07df5a
to
c5161d9
Compare
Description:
Some older devices did not have the open and close buttons for zwave.
This PR switches to use the old Inc and Dec buttons which is also present in new devices.
Also included is a workaround to disable level reporting with the SOMFY ZRTSI controller.
Related issue (if applicable): fixes #
#2849
@nunofgs @kuhlivisj @jsg4 Can you test this to confirm?