Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More generic use of up and down commands plus a workaround for SOMFY controller. #2852

Merged
merged 4 commits into from
Aug 20, 2016

Conversation

turbokongen
Copy link
Contributor

@turbokongen turbokongen commented Aug 16, 2016

Description:
Some older devices did not have the open and close buttons for zwave.
This PR switches to use the old Inc and Dec buttons which is also present in new devices.
Also included is a workaround to disable level reporting with the SOMFY ZRTSI controller.

Related issue (if applicable): fixes #
#2849

@nunofgs @kuhlivisj @jsg4 Can you test this to confirm?

@jsg4
Copy link

jsg4 commented Aug 16, 2016

Up functions but not lowering the shades. Also, I messaged you this before, but I'm not sure the purpose of greying both buttons out? Somfy zwave doesn't track state so it's not possible to see the position of the shades at the controller/zwave level. If the buttons weren't greyed out then it would be perfect. Thanks

@turbokongen
Copy link
Contributor Author

We are using the INC(Increment) command to open which equals UP or OPEN
Similar for DEC(Decrement) for down. These are the correct commands.
For current_position and move_postition we use LEVEL.
Could you please check the current_position value in the developer tools for open and closed? And which values you get, please?
I may have a solution depending on what values you get.

@jsg4
Copy link

jsg4 commented Aug 17, 2016

100 for closed, 0 for open.

@turbokongen
Copy link
Contributor Author

turbokongen commented Aug 17, 2016

That means level reporting is present. Looking at your zwcfg, all are at 99 which will be reported as 0, Open.https://github.com/turbokongen/home-assistant/blob/zwave_fixes/homeassistant/components/rollershutter/zwave.py#L77
So at 0(Open) The up button are greyed out, and at 100(Closed) The down button is greyed out?

@jsg4
Copy link

jsg4 commented Aug 17, 2016

Correct.

img_1189

@turbokongen
Copy link
Contributor Author

turbokongen commented Aug 17, 2016

By the look of it then, it works like it should?
Are both buttons greyed out anytime?

@jsg4
Copy link

jsg4 commented Aug 17, 2016

I am running 0.25.2 now, it was not functional in 0.26.2. I don't think both buttons are ever greyed out, the problem is sometimes it does not respond to the command because the state isn't matching.

@nunofgs
Copy link
Contributor

nunofgs commented Aug 17, 2016

@jsg4: that particular issue is already fixed in a PR I submitted here home-assistant/frontend#85 but haven't received a response yet.

@turbokongen turbokongen force-pushed the zwave_fixes branch 4 times, most recently from e0e8de3 to fc49c59 Compare August 17, 2016 14:16
@turbokongen turbokongen changed the title Support older devices More generic use of up and down commands plus a workaround for SOMFY controller. Aug 17, 2016
@turbokongen turbokongen force-pushed the zwave_fixes branch 5 times, most recently from fe60bab to f90b364 Compare August 17, 2016 15:44
@turbokongen
Copy link
Contributor Author

@nunofgs Does everything work as normal with this PR?

@turbokongen
Copy link
Contributor Author

So this has now been tested with the Somfy zrtsi which is a zwave to rf controller. Thank you @jsg4.
Now just need a confirmation for the old stuff😊

@balloob
Copy link
Member

balloob commented Aug 18, 2016

@turbokongen you can merge this when you see fit

@turbokongen turbokongen merged commit 6e672b7 into home-assistant:dev Aug 20, 2016
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants