Add config endpoint for scene #28429
Conversation
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
|
Thats a great feature. Do I have to change something here to stay compatible? #28300 |
Nope, don't think so. You don't want to set an ID as we can't edit a scene that is made with |
| elif cur_value[CONF_ID] == config_key: | ||
| break | ||
| else: | ||
| cur_value = OrderedDict() |
There was a problem hiding this comment.
Dicts are ordered by default in Python 3.6+.
There was a problem hiding this comment.
I'm not getting the same result using a dict
There was a problem hiding this comment.
The order of the dict seems ok, but I think PyYAML can't deal with it? The YAML is not sorted correctly.
bramkragten
force-pushed
the
config-scene
branch
from
44178f2 to
e7ba01a
Compare
Breaking Change:
Description:
Related issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: