Check for existence of system mode on Honeywell thermostats #2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if hasattr(self.device, 'system_mode'): | ||
| return self.device.system_mode | ||
| else: | ||
| return 'undefined' |
balloob
pushed a commit
that referenced
this pull request
Aug 14, 2016
* Check for existence of system mode on Honeywell thermostats * Return None instead of undefined * Use getattr instead of if/else
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Not all Honeywell thermostats have an HVAC mode (e.g. the ones commonly sold in Germany for district heating). In 0.26 the Honeywell component would fail setting up in that case, this check whether the
system_modeparameter exists before it does anything with itRelated issue (if applicable): extends #2757
Checklist:
If user exposed functionality or configuration variables are added/changed:
If code communicates with devices, web services, or a:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass