Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Re)Add support for multiple Pi-Holes #27569

Merged
merged 20 commits into from
Dec 12, 2019
Merged

(Re)Add support for multiple Pi-Holes #27569

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
060ee1d
Update configuration schema to support multiple Pi-holes
johnluetke Sep 30, 2019
32abe75
Construct sensors for each configured Pi-hole
johnluetke Sep 30, 2019
091c181
Ensure each Pi-hole has a unique name
johnluetke Oct 2, 2019
254164b
Update services to handle multiple Pi-holes
johnluetke Oct 2, 2019
ecba3f4
Update tests for multiple configurations
johnluetke Oct 2, 2019
4241cd4
Refactor tests to support service testing
johnluetke Oct 3, 2019
8fc853e
Fix else-raise per pyliunt
johnluetke Oct 13, 2019
97b2e19
Per code review, add all entities in a single call
johnluetke Nov 9, 2019
4fb5b5f
Per code review, add the default name as default.
johnluetke Nov 9, 2019
1a7aed4
Per code review, add cv.ensure_list to prevent breaking change
johnluetke Nov 9, 2019
a55dcdd
Per code review, move name validation to schema
johnluetke Nov 9, 2019
fa275b6
Remove default name
johnluetke Nov 10, 2019
ddae0fe
Per code review, validate api_key in schema definition
johnluetke Nov 10, 2019
d002897
Per code review, rename variables
johnluetke Nov 10, 2019
97e11ba
Per code review, use list comprehension
johnluetke Nov 10, 2019
8d9dc64
Ensure unique slug names in config validation
johnluetke Nov 16, 2019
5148a90
Per code review, refactor to CoroutineMock
johnluetke Nov 17, 2019
e48bd54
Fix adding sensor entities
johnluetke Nov 17, 2019
28b9fce
Per code review, refactor mock function creation
johnluetke Nov 23, 2019
c2f1dc3
Per code review, refactor mock function return values
johnluetke Nov 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests for multiple configurations
  • Loading branch information
@johnluetke
johnluetke committed Nov 23, 2019
commit ecba3f427cdbf9782dbdccce8c771b12d50e3cc0
12 changes: 8 additions & 4 deletions tests/components/pi_hole/test_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,14 @@ def mock_pihole_data_call(Hole):
pass


async def test_setup_no_config(hass):
"""Tests component setup with no config."""
async def test_setup_minimal_config(hass):
"""Tests component setup with minimal config."""
with patch.object(
Hole, "get_data", new=CoroutineMock(side_effect=mock_pihole_data_call(Hole))
):
assert await async_setup_component(hass, pi_hole.DOMAIN, {pi_hole.DOMAIN: {}})
assert await async_setup_component(
hass, pi_hole.DOMAIN, {pi_hole.DOMAIN: [{"host": "pi.hole"}]}
)

await hass.async_block_till_done()

Expand Down Expand Up @@ -88,7 +90,9 @@ async def test_setup_custom_config(hass):
Hole, "get_data", new=CoroutineMock(side_effect=mock_pihole_data_call(Hole))
):
assert await async_setup_component(
hass, pi_hole.DOMAIN, {pi_hole.DOMAIN: {"name": "Custom"}}
hass,
pi_hole.DOMAIN,
{pi_hole.DOMAIN: [{"host": "pi.hole", "name": "Custom"}]},
)

await hass.async_block_till_done()
Expand Down